Forum Home
    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Popular

    [DEV] Fix automatic unit tests Feathercoin 0.9.6 [Completed 29th Jan 2017]

    Technical Development
    3
    27
    15092
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • AcidD
      AcidD Moderators last edited by

      Staying on topic ;-)

      I’ve moved this back to “In Progress” - Explanation below:

      When you build Feathercoin-QT with the tests the following binaries get built

      /src/feathercoind
      /src/test/test_bitcoin (the feathercoind test)

      /src/qt/feathercoin-qt
      /src/qt/test/test_feathercoin-qt (the gui test)

      I apologise but this slipped my mind and while the test program builds with no complaints…we have some interesting stuff in the console print out when we run ./test_feathercoin-qt

      see below:

      aciddude@osboxes:~/Feathercoin/build/bin$ ./test_bitcoin-qt 
      ********* Start testing of URITests *********
      Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.4.0 20160609)
      PASS   : URITests::initTestCase()
      FAIL!  : URITests::uriTests() 'GUIUtil::parseBitcoinURI(uri, &rv)' returned FALSE. ()
         Loc: [uritests.cpp(16)]
      PASS   : URITests::cleanupTestCase()
      Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
      ********* Finished testing of URITests *********
      ********* Start testing of PaymentServerTests *********
      Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.4.0 20160609)
      PASS   : PaymentServerTests::initTestCase()
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::initNetManager : No active proxy server found.
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest : Secure payment request from  "testmerchant.org"
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : Payment request: certificate expired or not yet active:  QSslCertificate("3", "03", "LxHILx+N3qwVoAcCmQ5cyw==", (), ("Expired Test Merchant"), QMap(), QDateTime(2013-02-23 21:26:43.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 21:26:43.000 UTC Qt::TimeSpec(UTC)))
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest : Insecure payment request to  "6sMH7m11qaUoZX2coz5oe33R64eGHQCAKi"
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : Payment request: certificate expired or not yet active:  QSslCertificate("3", "03", "LxHILx+N3qwVoAcCmQ5cyw==", (), ("Expired Test Merchant"), QMap(), QDateTime(2013-02-23 21:26:43.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 21:26:43.000 UTC Qt::TimeSpec(UTC)))
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest : Secure payment request from  "testmerchant8.org"
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : Payment request: certificate expired or not yet active:  QSslCertificate("3", "06", "MiZaQ+g9lSHZGuHWkXZG+g==", (), ("Payment Request Intermediate 5"), QMap(), QDateTime(2013-02-23 22:59:51.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 22:59:51.000 UTC Qt::TimeSpec(UTC)))
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest : Insecure payment request to  "6sMH7m11qaUoZX2coz5oe33R64eGHQCAKi"
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : Payment request: certificate expired or not yet active:  QSslCertificate("3", "06", "MiZaQ+g9lSHZGuHWkXZG+g==", (), ("Payment Request Intermediate 5"), QMap(), QDateTime(2013-02-23 22:59:51.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 22:59:51.000 UTC Qt::TimeSpec(UTC)))
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : SSL error:  certificate signature failure
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest : Insecure payment request to  "6sMH7m11qaUoZX2coz5oe33R64eGHQCAKi"
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : SSL error:  certificate signature failure
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : SSL error:  unable to get local issuer certificate
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest : Insecure payment request to  "6sMH7m11qaUoZX2coz5oe33R64eGHQCAKi"
      QDEBUG : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant : SSL error:  unable to get local issuer certificate
      PASS   : PaymentServerTests::paymentServerTests()
      PASS   : PaymentServerTests::cleanupTestCase()
      Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted
      ********* Finished testing of PaymentServerTests *********
      aciddude@osboxes:~/Feathercoin/build/bin$
      

      I’ll see if I can put in the time to get this working before the 0.9.6 release.

      • FTC Block Explorer + API @ https://fsight.chain.tips
      • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
      • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
      • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

      1 Reply Last reply Reply Quote 1
      • Wellenreiter
        Wellenreiter Moderators last edited by

        I don’t think that is a problem with the test code, it complains about the SSL certificate missing. It does not fail.
        I’ve never checked, where SSL really is used, but installing the correct certificate should make the test work without complains.

        Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
        Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

        AcidD 1 Reply Last reply Reply Quote 1
        • AcidD
          AcidD Moderators @Wellenreiter last edited by AcidD

          @Wellenreiter said in [DEV] Fix automatic unit tests Feathercoin 0.9.6 [In Progress]:

          I don’t think that is a problem with the test code, it complains about the SSL certificate missing. It does not fail.
          I’ve never checked, where SSL really is used, but installing the correct certificate should make the test work without complains.

          Yes you’re 100% correct. you have to actually pass it a valid certificate.

          The URI tests I’ve fixed. it’s a very basic bitcoin:// to feathercoin:// will submit a PR soon.

          once the URI test is fixed then all our tests are passing 100%.

          • FTC Block Explorer + API @ https://fsight.chain.tips
          • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
          • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
          • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

          1 Reply Last reply Reply Quote 1
          • AcidD
            AcidD Moderators last edited by

            URI tests fixed in PR https://github.com/FeatherCoin/Feathercoin/pull/154

            Marked as completed: 29-01-2017

            • FTC Block Explorer + API @ https://fsight.chain.tips
            • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
            • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
            • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

            1 Reply Last reply Reply Quote 2
            • wrapper
              wrapper Moderators last edited by

              I’ll start a thread to cover the 0.11 tests, when we start moving this work over…

              AcidD 1 Reply Last reply Reply Quote 1
              • AcidD
                AcidD Moderators @wrapper last edited by

                @wrapper said in [DEV] Fix automatic unit tests Feathercoin 0.9.6 [Completed 29th Jan 2017]:

                I’ll start a thread to cover the 0.11 tests, when we start moving this work over…

                When I fixed the 0.9.6 tests I had a look at the code for Bitcoins 0.11 tests, there’s a few things that have changed so I doubt any of my test fixes will work for 0.11…not 100% sure tho.

                • FTC Block Explorer + API @ https://fsight.chain.tips
                • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
                • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
                • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

                Wellenreiter 1 Reply Last reply Reply Quote 1
                • Wellenreiter
                  Wellenreiter Moderators @AcidD last edited by

                  When I fixed the 0.9.6 tests I had a look at the code for Bitcoins 0.11 tests, there’s a few things that have changed so I doubt any of my test fixes will work for 0.11…not 100% sure tho.

                  As long as the data used is the same, it should be ok.

                  Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                  Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                  1 Reply Last reply Reply Quote 1
                  • First post
                    Last post